do you ever give unsolicited advice?

No. IMHO, 99% of the time it comes across as obnoxious.

There have been times I really wanted to when I see someone regularly at the pool floundering but I keep my mouth shut.  Whence you start where do you stop?  If someone asks I'll certainly take the time but it is very unlikely anyone asks.

I would probably try to make myself available to help (ie take a break at the wall with them) but I wouldn't jump into advice giving unless asked. 

Not exactly sure what you would say anyway?  If he was simply a new swimmer and totally out of swim shape and couldn't make it 50 yds without stopping, what can you say?  Train more?   On the other hand, if you both happen to be taking a break at the wall and you exchange "how's it going?" out of general courtesy and he opens up first and says he needs help then the door is open.....

In general no.  I simply don't have the energy.  And for some reason, despite having been in this sport almost 10 years, and having completed 6 IMs, it seems like at every race of any distance people think its my first.  Yeah my body fat is over 2% but still....do you REALLY think a 1st timer would have a $4000 bike with race wheels?  REALLY?  Do I LOOK like I REALLY need help setting up my transition area...mind your own beeswax.  Pisses me off.  If someone asks for help I always help tho.

Interesting because I have received unsolicited advice in the pool and was very appreciative at the time. It was very simple "would you like some help with your stroke?" Me - YES! The person who asked was a swim instructor and I wound up signing up for his beginning swimming classes.

I always think of that day when I see people struggling in the pool but I never say anything because 1.) I am not a swim instructor and 2.) our Y is full of swim instructors who may not appreciate me giving out free advice . Sometimes beginners will comment about my swimming. I make sure to tell them that I've had lessons and refer them to a class or private instructor. 

It depends on the circumstance.

If it's a masters swim and someone in my lane or who's clearly trying to get better has an obvious stroke deficit that they're not noticing, I'll comment on it.

If it's anything else, I won't. Because quite a lot of folks are perfectly happy at their pace, whether it's slow or inefficient or not, and are content with just getting a decent workout. 

The pool is, of course, the one area where this comes up a lot.  I do the same as another person suggested, which is try to time breaks and make myself available if the person looks like they are floundering and may be open to help.   I may also smile or try to engage them (without being creepy) so they know I am approachable.   Usually I hold my tongue unless asked.

I don't really want to spend a bunch of time, but so often there are quick things you can recommend without being overwhelming.    I also think that people may not realize some obvious flaws that you just need another set of eyes to tell you about, like crossing the midline.   

I'll usually give them the "How's it going?" and sort of determine based on their answer & the conversation that follows (if any) if I should say anything. 

When I want help, I'll usually just ask... like "how do you keep your arms so relaxed when you run" or show up to a roadie ride and apologize for being a triathlete  

Sometimes, but I always ask them if they want some advice or a tip first. I've been riding at the velodrome for awhile now, so my skills are decent. There's always a lot of new guys who are strong, but lack skills, so we often end up in the same race or workout. If I notice something obvious and think I can help them, after we get off of the track, I usually ask them, "Hey do you want some advice?" They seem to appreciate it.

I'm surprised at the number of flat out "no's" to your question. 

When I first got into the sport I was struggling to maintain good form and needed some help.  Well, I needed alot of help.  Roger, a local legend in our area, was in the pool doing his sets and was watching me at the same time.  He asked "would you mind if I gave you a couple of tips?" 

Roger has helped me become a FOP swimmer over the last 3 years and I would have been embarrassed to ask for help.

Now I'm the guy that asks that same questoin and I get at least a 90% positive response.  The ones that don't want help are not douchey about it either. 

Interesting thread though.

I don't think I've ever given unsolicited advice in that situation.  IMO, unsolicited advice is more likely not to be received well compared to if you just strike up a conversation about how things are going and be friendly.  Sometimes that leads to them asking for tips.  Sometimes it doesn't.  Either way, I'm not pushing the matter.

I've had more people approach me and ask for advice after seeing what my swimming looks like.  At that point I give them some suggestions, and offer them my card.  This happened to me a few months ago with one guy in particular, and we became facebook friends.  Three weeks ago he came on board with me as a coached athlete.